Fix OpenFeedback id mission in live view #758
Conversation
👷 Deploy request for dev-bcn pending review.Visit the deploys page to approve it
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @HugoGresse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in the live view where the OpenFeedback ID was not being correctly passed to the TalkCard component. The fix involves importing conference data and updating the talkCardAdapter function to include the openFeedbackId in the props passed to the TalkCard.
Highlights
- Bug Fix: This PR fixes an issue where the OpenFeedback ID was not correctly being passed to the TalkCard component in the live view.
- Data Import: Imports conference data from
@data/2025.jsonto access theopenFeedbackId. - Component Update: Modifies the
talkCardAdapterfunction to include theopenFeedbackIdprop when creating theTalkCardPropsobject.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces the openFeedbackId property to the TalkCardProps object, fetching it from a JSON configuration file. A suggestion was made to consider using environment variables or a configuration service for better flexibility and to add a check for the existence of conferenceData.openFeedbackId to prevent potential errors.
|
@HugoGresse nice catch, thanks! |
2 participants
did not test though /^^/